Add netssh sftp and netssh scp. Both resolve the host like a connection does (cache, shortcuts and rewrites, instance/host, default user and port, SSH options and rules, --jump/--no-jump, --dry-run) and get shell completion. The per-client flag tables handle the differences from ssh: the port is -P, -l is a bandwidth limit (the default user goes in as -o User=), and IPv6 addresses are bracketed in host:path. All remote scp operands must name the same host. Add named port forwards under ssh.forwards (global, per instance, per rule; a more specific layer replaces a forward of the same name), netssh tunnel HOST NAME|SPEC... (ssh -N with ExitOnForwardFailure) and netssh --forward NAME. Specs such as 8080:localhost:80 work without configuration. Forwards are editable in netssh configure and completed in the shell; the TUI opens SFTP with ctrl+o and a tunnel with ctrl+t. Host resolution moves out of runSSHWrapper into resolveTarget, shared by ssh, sftp, scp, tunnel, and the TUI. Options added by netssh are now inserted before the first operand or "--": after "--", ssh read them as the destination, and scp stops reading options at the first operand. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
138 lines
3.9 KiB
Go
138 lines
3.9 KiB
Go
package config
|
|
|
|
import (
|
|
"os"
|
|
"path/filepath"
|
|
"reflect"
|
|
"strings"
|
|
"testing"
|
|
)
|
|
|
|
func loadYAML(t *testing.T, data string) (*Config, error) {
|
|
t.Helper()
|
|
dir := t.TempDir()
|
|
t.Setenv("XDG_CONFIG_HOME", dir)
|
|
t.Setenv("HOME", t.TempDir())
|
|
if err := os.WriteFile(filepath.Join(dir, "netssh.yaml"), []byte(data), 0o600); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
return Load()
|
|
}
|
|
|
|
func TestSSHOptionsLayering(t *testing.T) {
|
|
cfg, err := loadYAML(t, `
|
|
netboxes:
|
|
- name: prod
|
|
url: https://prod.example.com
|
|
ssh:
|
|
proxy_jump: jh-prod.example.com
|
|
host_key_checking: strict
|
|
- name: staging
|
|
url: https://staging.example.com
|
|
ssh:
|
|
host_key_checking: off
|
|
ssh:
|
|
proxy_jump: jh.example.com
|
|
extra_args: ["-4"]
|
|
options:
|
|
ServerAliveInterval: 60
|
|
ServerAliveCountMax: 5
|
|
rules:
|
|
- match: {tag: dmz}
|
|
proxy_jump: jh-dmz.example.com
|
|
options: {ServerAliveInterval: 10}
|
|
- match: {instance: prod, name: "db*"}
|
|
proxy_jump: none
|
|
completion:
|
|
max_results: 200
|
|
`)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if cfg.Completion.MaxResults != 200 {
|
|
t.Fatalf("max_results: %d", cfg.Completion.MaxResults)
|
|
}
|
|
for _, tc := range []struct {
|
|
host SSHHost
|
|
jump, keys, alive string
|
|
}{
|
|
{SSHHost{Name: "web"}, "jh.example.com", "", "60"},
|
|
{SSHHost{Instance: "prod", Name: "web"}, "jh-prod.example.com", "strict", "60"},
|
|
{SSHHost{Instance: "staging", Name: "web", Tags: []string{"DMZ"}}, "jh-dmz.example.com", "off", "10"},
|
|
{SSHHost{Instance: "prod", Name: "db01", Tags: []string{"dmz"}}, "none", "strict", "10"},
|
|
} {
|
|
got := cfg.SSHOptionsFor(tc.host)
|
|
if got.ProxyJump != tc.jump || got.HostKeyChecking != tc.keys || got.Options["serveraliveinterval"] != tc.alive || got.Options["serveralivecountmax"] != "5" {
|
|
t.Errorf("%+v: got %+v", tc.host, got)
|
|
}
|
|
if !reflect.DeepEqual(got.ExtraArgs, []string{"-4"}) {
|
|
t.Errorf("extra args: %v", got.ExtraArgs)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestSSHOptionsValidation(t *testing.T) {
|
|
for _, data := range []string{
|
|
"ssh:\n host_key_checking: maybe\n",
|
|
"ssh:\n target: dns\n",
|
|
"ssh:\n address_family: ipx\n",
|
|
"ssh:\n proxy_jump: \"-oProxyCommand=x\"\n",
|
|
"ssh:\n options:\n \"bad key\": 1\n",
|
|
"ssh:\n rules:\n - proxy_jump: jh\n",
|
|
"netboxes:\n - name: a\n url: https://a.example\n ssh:\n target: nope\n",
|
|
} {
|
|
if _, err := loadYAML(t, data); err == nil {
|
|
t.Errorf("accepted invalid config:\n%s", data)
|
|
} else if !strings.Contains(err.Error(), "ssh") {
|
|
t.Errorf("unclear error %v", err)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestForwardsLayering(t *testing.T) {
|
|
cfg, err := loadYAML(t, `
|
|
netboxes:
|
|
- name: prod
|
|
url: https://prod.example
|
|
token: t
|
|
ssh:
|
|
forwards:
|
|
db: {local: "5432:localhost:5432"}
|
|
ssh:
|
|
forwards:
|
|
web: {local: "8080:localhost:80"}
|
|
socks: {dynamic: "1080"}
|
|
rules:
|
|
- match: {tag: dmz}
|
|
forwards:
|
|
web: {local: "8443:localhost:443"}
|
|
`)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
got := cfg.SSHOptionsFor(SSHHost{Instance: "prod", Name: "web01", Tags: []string{"dmz"}}).Forwards
|
|
want := map[string]Forward{"web": {Local: "8443:localhost:443"}, "socks": {Dynamic: "1080"}, "db": {Local: "5432:localhost:5432"}}
|
|
if !reflect.DeepEqual(got, want) {
|
|
t.Fatalf("got %+v", got)
|
|
}
|
|
if got := cfg.SSHOptionsFor(SSHHost{Instance: "other", Name: "web01"}).Forwards; len(got) != 2 || got["web"].Local != "8080:localhost:80" {
|
|
t.Fatalf("other instance: %+v", got)
|
|
}
|
|
if f := (Forward{Remote: "9000:localhost:9000"}); f.String() != "-R 9000:localhost:9000" {
|
|
t.Fatal(f.String())
|
|
}
|
|
}
|
|
|
|
func TestForwardsValidation(t *testing.T) {
|
|
for _, forwards := range []string{
|
|
`web: {local: "8080:a:80", dynamic: "1080"}`,
|
|
`web: {local: "-oProxyCommand=x"}`,
|
|
`web: {local: "8080 a:80"}`,
|
|
`"bad name": {local: "8080:a:80"}`,
|
|
} {
|
|
if _, err := loadYAML(t, "ssh:\n forwards:\n "+forwards+"\n"); err == nil || !strings.Contains(err.Error(), "forwards") {
|
|
t.Errorf("%s: got %v", forwards, err)
|
|
}
|
|
}
|
|
}
|